Skip to content

Support for Pylint 3#1

Merged
federicobond merged 1 commit into
federicobond:masterfrom
alejofl:support-pylint3
Oct 31, 2023
Merged

Support for Pylint 3#1
federicobond merged 1 commit into
federicobond:masterfrom
alejofl:support-pylint3

Conversation

@alejofl

@alejofl alejofl commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Pylint 3 made some breaking changes to classes and functions used by this dependency.

  • Everything related to the __implements__ construct was removed.
    • As suggested, I removed all of the appearances of it on the code, and the checker now only inherits from BaseChecker
  • The deprecated decorator check_message() was removed.
    • Replaced all of its ocurrances with only_required_for_messages()

Also replaced the Message class in the test file, using the corresponding testutils class, MessageTest.

All pylint 3 changes can be accesed here

@federicobond

Copy link
Copy Markdown
Owner

Awesome! Thank you for the pull request. Will release a new version right away.

@federicobond federicobond merged commit 3d068a0 into federicobond:master Oct 31, 2023
@federicobond

Copy link
Copy Markdown
Owner

I've uploaded pylint==0.2.0 to PyPI. Can you verify that it works?

@alejofl

alejofl commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

It seems to be working just fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants